Download json schema catalog at build-time instead of run-time #14065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes eclipse-theia#11881 Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
|
@msujew I seem to have a "works on my machine" problem here. Maybe hold off on the review until I have fixed it. |
Our CI build never invokes "build" on the core package. Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
|
@msujew turns out our CI build script does not actually invoke |
msujew
approved these changes
Aug 26, 2024
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
|
@msujew I added a flag that overwrites the file if you already have a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This fixes the problem where we run into timeout at front-end start time because downloading the json schema catalog takes longer than expected. We now download the catalog as part of the core package build and just
require()the json file at run time.Fixes #11881
Contributed on behalf of STMicroelectronics
How to test
Build Theia from source and make sure that there are no errors at startup. Also check that json files that are on the schemastore.org catalog have proper code assist according to their schema.
Follow-ups
Review checklist
Reminder for reviewers