Update keytar and drivelist #14306
Merged
Update keytar and drivelist #14306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@msujew Do you know how to test the features using keytar and drivelist? Could you take over finishing this PR? |
|
@msujew :-) |
|
@JonasHelming I've rebased the changes and added some more tests to ensure that everything works as expected. Now we need a reviewer :) |
|
@tsmaeder Ping |
fixed #14305 Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
tsmaeder
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #14305
Review checklist
Reminder for reviewers