Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome Widget: Mark recent workspaces as DevContainer #14595

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jbicker
Copy link
Contributor

@jbicker jbicker commented Dec 6, 2024

What it does

In Recent Workspaces List in Welcome Widget workspaces which were recently opened in a DevContainer are marked as such.

How to test

Open a workspace in DevContainer. Reopen the Theia app and see the last workspace marked as DevContainer.

Review checklist

Reminder for reviewers

@jbicker jbicker requested a review from jonah-iden December 6, 2024 08:18
@jbicker jbicker force-pushed the jbicker/show-devcontainer-in-welcome-recentlist branch 3 times, most recently from cd8ffb2 to 8f12c49 Compare December 6, 2024 11:40
Copy link
Contributor

@jonah-iden jonah-iden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it would be nicer to have still have the local workspace path in the grey text and the devcontainer info in the blue clickable one. And then don't use the full devcontainer.json path. Maybe just either the name of the directory its in or just [Dev Container] if there only is one devcontainer file without subdirectories in the .devcontainer folder

@jbicker jbicker force-pushed the jbicker/show-devcontainer-in-welcome-recentlist branch from 8f12c49 to ed4fc3c Compare December 20, 2024 10:53
@jbicker jbicker requested a review from jonah-iden December 20, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting on reviewers
Development

Successfully merging this pull request may close these issues.

2 participants