-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workspace folders API #2141
Workspace folders API #2141
Conversation
packages/plugin/src/theia.d.ts
Outdated
* | ||
* @readonly | ||
*/ | ||
export let rootPath: string | undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is deprecated field in vscode workspace api, can you remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
||
private folders: WorkspaceFolder[] | undefined; | ||
|
||
constructor(rpc: RPCProtocol) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need rpc here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed. Thanks
36389a6
to
27c0cd9
Compare
|
||
// tslint:disable-next-line:no-unused-variable | ||
// @ts-ignore | ||
const workspaceMain = new WorkspaceMain(rpc, workspaceService); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to declare the variable ? if not used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed. Thanks.
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
5fe3b12
to
1855322
Compare
Plugin API to get information about workspace folder.
Signed-off-by: Vitaliy Gulyy vgulyy@redhat.com