[plug-in] Create plug-in api objects after plug-in initialization #2227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evidolob
added
plug-in system
benoitf
reviewed
Jun 28, 2018
| @@ -115,7 +116,7 @@ export class HostedPluginSupport { | |||
| childProcess.stdout.on('data', data => this.logger.info(`[${options.serverName}: ${childProcess.pid}] ${data.toString()}`)); | |||
| childProcess.stderr.on('data', data => this.logger.error(`[${options.serverName}: ${childProcess.pid}] ${data.toString()}`)); | |||
|
|
|||
| this.logger.debug(`[${options.serverName}: ${childProcess.pid}] IPC started`); | |||
| this.logger.error(`[${options.serverName}: ${childProcess.pid}] IPC started`); | |||
benoitf
approved these changes
Jun 28, 2018
evidolob
added a commit
that referenced
this pull request
Jun 28, 2018
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
benoitf
approved these changes
Jun 28, 2018
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
evidolob
force-pushed
the
fix-editor-event
branch
from
64beafb
to
1a20ce3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2190
Signed-off-by: Yevhen Vydolob yvydolob@redhat.com