[plug-in] Languages API - Register hover provider #2869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces the ability to register a hover provider. Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
benoitf
changed the title
benoitf
reviewed
Sep 13, 2018
| @@ -189,7 +189,7 @@ export class DocumentDataExt { | |||
| } | |||
|
|
|||
| if (range.isSingleLine) { | |||
| return this.lines[range.start.line].substring(range.start.character, range.end.character); | |||
| return this.lines[range.start.line - 1].substring(range.start.character, range.end.character); | |||
There was a problem hiding this comment.
do we have some tests for the range ?
There was a problem hiding this comment.
AFAIK we do not have any test for API so far
benoitf
approved these changes
Sep 13, 2018
evidolob
approved these changes
Sep 13, 2018
mmorhun
approved these changes
Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Oleksii Kurinnyi okurinny@redhat.com
This PR adds the ability to register custom hover provider. Now it is possible to show hover messages from a plugin.
resolves #2601