preferences for multi-root workspace #3247

elaihau · 2018-10-22T18:34:32Z

With changes in 543b119, URIs of root folders in a multi-root workspace are stored in a file with the extension of "theia-workspace", while the workspace preferences are in the ".theia/settings.json" under the first root.

In this pull request, workspace preferences are stored

in the workspace file under the "settings" property, if a workspace file exists, or
in the ".theia/settings.json" if the workspace data is not saved in a workspace file.

Also, this change supports

having 4 levels of preferences (from highest priority to the lowest): FolderPreference, WorkspacePreference, UserPreference, and DefaultPreference, with
an updated preference editor that supports viewing & editing the FolderPreferences, WorkspacePreferences, and UserPreferneces.

Signed-off-by: elaihau liang.huang@ericsson.com

paul-marechal · 2018-10-23T07:17:36Z

It seems like one of your components that is getting tested with mocha relies on some frontend package, somehow: https://travis-ci.org/theia-ide/theia/jobs/444752934#L2333

The tests run in node, so if some nested import from a chain of "require" happen to import something from phosphor indirectly, it will fail the tests, because phosphor seems to have side effects (code executed on importation) targeting a browser environment.

akurinnoy · 2018-11-05T14:23:33Z

Hello, @elaihau

I am working on the issue for plug-ins to implement inspect for Configuration API (#2289), so I'm really looking forward to this PR to be merged.

What is the status of this PR? Is it going to be merged soon?

akosyakov · 2018-11-05T14:52:50Z

What is the status of this PR? Is it going to be merged soon?

Someone should test this PR, and review that there are no breaking changes in API and behavior.

packages/preferences/src/browser/preferences-tree-widget.ts

elaihau · 2018-11-05T15:22:38Z

@akurinnoy this pr is being reviewed by @lmcbout and others from the Ericsson team. You are also welcomed to give us any suggestions :)

hi @akosyakov, this pr is tested by @lmcbout and myself from the functionality standpoint, but i am not sure if we covered all the cases. could someone from typefox do a quick test in near future?

packages/core/src/browser/preferences/preference-contribution.ts

packages/core/src/browser/preferences/preference-provider.ts

packages/core/src/browser/preferences/preference-service.ts

packages/core/src/browser/preferences/preference-contribution.ts

packages/core/src/browser/preferences/test/mock-preference-provider.ts

packages/preferences/src/browser/abstract-resource-preference-provider.ts

packages/workspace/src/browser/workspace-service.ts

akosyakov · 2019-01-28T08:55:26Z

browser console full of errors if try to edit setting files:

Reproducible by adding files.watcherExclude into workspace preferences.

elaihau · 2019-01-28T16:55:56Z

browser console full of errors if try to edit setting files:
Reproducible by adding files.watcherExclude into workspace preferences.

Thank you for the review. The bug was fixed.

elaihau · 2019-01-30T20:07:55Z

resolved conflicts between this PR and 6b1a35c

elaihau · 2019-01-31T13:22:09Z

@akosyakov I noticed that you bumped the version to 0.4.x. Can I also take advantage of the version change and merge this PR in near future ?

akosyakov · 2019-01-31T15:18:45Z

@elaihau i've looked at the code, thank you for the effort, now it has much less incompatible changes than an original version. It is easier to follow without being afraid that something broken.

Unfortunately, they are still new mandatory arguments, so yes the major version is required. Could you add a record in Change Log under Breaking Changes? I would test tomorrow again and hopefully we can merge afterwards.

elaihau · 2019-01-31T20:30:05Z

Could you add a record in Change Log under Breaking Changes?

Yes. Done.

I would test tomorrow again and hopefully we can merge afterwards.

Thank you !

akosyakov · 2019-02-01T06:58:12Z

CHANGELOG.md

@@ -15,6 +15,10 @@ Breaking changes:
    - `3_move` and `7_actions` replaced by `navigation` group
  - editor context menu group changes:
    - `2_cut_copy_paste` renamed to `9_cutcopypaste` group
+- [core] `PreferenceProvider` [#3247](https://github.com/theia-ide/theia/pull/3247)


i would group them under multi-root workspace support for preferences. There are more incompatible changes to what is listed here.

i updated the list. could you check if there are items missing?

packages/workspace/src/browser/workspace-service.ts

akosyakov · 2019-02-01T07:17:51Z

It seems to behave properly. @svenefftinge Can you test it as well?

svenefftinge

LGTM

elaihau · 2019-02-01T12:09:10Z

@benoitf @evidolob could you please check if this PR is ok for plugin developers ? Thank you !

With changes in 543b119, URIs of root folders in a multi-root workspace are stored in a file with the extension of "theia-workspace", while the workspace preferences are in the ".theia/settings.json" under the first root. In this pull request, workspace preferences are stored - in the workspace file under the "settings" property, if a workspace file exists, or - in the ".theia/settings.json" if the workspace data is not saved in a workspace file. Also, this change supports - having 4 levels of preferences (from highest priority to the lowest): FolderPreference, WorkspacePreference, UserPreference, and DefaultPreference, with - an updated preference editor that supports viewing & editing the FolderPreferences, WorkspacePreferences, and UserPreferneces. - Internally, vsCode uses an enum to define the preference scope. External extensions, however, make contributions to preference schemas by having schemas defined in the package.json, where the preference scope is a string enum of "window", "application", and "resource". This change updates the PreferenceSchema interface defined in theia, to allow contribution points to define scopes with strings. - Added affects() function to PreferenceChange, to help client decide whether or not the preference change matters. Signed-off-by: elaihau <liang.huang@ericsson.com>

elaihau · 2019-02-04T15:12:38Z

ping @evidolob and @benoitf one more time for approval :)

elaihau requested review from svenefftinge and lmcbout October 22, 2018 18:34

elaihau force-pushed the pref-editor branch from 900c6bb to 53c75c5 Compare October 22, 2018 18:50

elaihau requested a review from marcdumais-work October 22, 2018 19:01

elaihau force-pushed the pref-editor branch 8 times, most recently from bcd31a1 to 964c0df Compare October 30, 2018 10:39

lmcbout mentioned this pull request Oct 30, 2018

[Preferences] Adjust tool tip text when the preference is not defined. #3334

Closed

elaihau force-pushed the pref-editor branch 2 times, most recently from ef52d69 to b593f38 Compare October 31, 2018 15:50

elaihau requested review from benoitf and evidolob as code owners October 31, 2018 15:50

elaihau force-pushed the pref-editor branch 2 times, most recently from 1c13c97 to e043244 Compare November 1, 2018 13:05

lmcbout reviewed Nov 5, 2018

View reviewed changes

packages/preferences/src/browser/preferences-tree-widget.ts Outdated Show resolved Hide resolved

elaihau force-pushed the pref-editor branch from e043244 to 7c201ea Compare November 5, 2018 15:33

akosyakov reviewed Nov 5, 2018

View reviewed changes

packages/core/src/browser/preferences/preference-contribution.ts Outdated Show resolved Hide resolved

akosyakov reviewed Nov 5, 2018

View reviewed changes

packages/core/src/browser/preferences/preference-provider.ts Show resolved Hide resolved

akosyakov reviewed Nov 5, 2018

View reviewed changes

packages/core/src/browser/preferences/preference-provider.ts Outdated Show resolved Hide resolved

akosyakov reviewed Nov 5, 2018

View reviewed changes

packages/core/src/browser/preferences/preference-service.ts Show resolved Hide resolved

vince-fugnitto reviewed Nov 5, 2018

View reviewed changes

packages/core/src/browser/preferences/preference-contribution.ts Outdated Show resolved Hide resolved

akosyakov reviewed Jan 28, 2019

View reviewed changes

packages/core/src/browser/preferences/test/mock-preference-provider.ts Outdated Show resolved Hide resolved

akosyakov reviewed Jan 28, 2019

View reviewed changes

packages/preferences/src/browser/abstract-resource-preference-provider.ts Outdated Show resolved Hide resolved

akosyakov reviewed Jan 28, 2019

View reviewed changes

packages/preferences/src/browser/abstract-resource-preference-provider.ts Outdated Show resolved Hide resolved

akosyakov reviewed Jan 28, 2019

View reviewed changes

packages/workspace/src/browser/workspace-service.ts Outdated Show resolved Hide resolved

elaihau force-pushed the pref-editor branch from c87f47d to 6079dfc Compare January 28, 2019 16:53

elaihau force-pushed the pref-editor branch 2 times, most recently from 0099db4 to d97cd0c Compare January 28, 2019 19:12

evidolob mentioned this pull request Jan 30, 2019

IDE2-2019-02-26 (Sprint: 162) eclipse-che/che#12551

Closed

43 tasks

elaihau force-pushed the pref-editor branch 2 times, most recently from 986662f to 08c1281 Compare January 30, 2019 20:02

elaihau force-pushed the pref-editor branch from 08c1281 to f7c83f8 Compare January 31, 2019 20:27

akosyakov reviewed Feb 1, 2019

View reviewed changes

packages/workspace/src/browser/workspace-service.ts Outdated Show resolved Hide resolved

svenefftinge approved these changes Feb 1, 2019

View reviewed changes

elaihau force-pushed the pref-editor branch from f7c83f8 to 5af0345 Compare February 1, 2019 12:06

elaihau force-pushed the pref-editor branch from 5af0345 to f0dbaf7 Compare February 1, 2019 12:09

evidolob approved these changes Feb 4, 2019

View reviewed changes

elaihau merged commit a2fa904 into eclipse-theia:master Feb 4, 2019

elaihau deleted the pref-editor branch February 4, 2019 15:37

akosyakov mentioned this pull request Feb 7, 2019

PreferenceRegistryExtImpl.$acceptConfigurationChanged: Cannot read property 'split' of undefined #4280

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

preferences for multi-root workspace #3247

preferences for multi-root workspace #3247

elaihau commented Oct 22, 2018 •

edited

Loading

paul-marechal commented Oct 23, 2018

akurinnoy commented Nov 5, 2018

akosyakov commented Nov 5, 2018 •

edited

Loading

elaihau commented Nov 5, 2018 •

edited

Loading

akosyakov commented Jan 28, 2019 •

edited

Loading

elaihau commented Jan 28, 2019

elaihau commented Jan 30, 2019

elaihau commented Jan 31, 2019

akosyakov commented Jan 31, 2019 •

edited

Loading

elaihau commented Jan 31, 2019

akosyakov Feb 1, 2019

elaihau Feb 1, 2019

akosyakov commented Feb 1, 2019

svenefftinge left a comment

elaihau commented Feb 1, 2019

elaihau commented Feb 4, 2019

preferences for multi-root workspace #3247

preferences for multi-root workspace #3247

Conversation

elaihau commented Oct 22, 2018 • edited Loading

paul-marechal commented Oct 23, 2018

akurinnoy commented Nov 5, 2018

akosyakov commented Nov 5, 2018 • edited Loading

elaihau commented Nov 5, 2018 • edited Loading

akosyakov commented Jan 28, 2019 • edited Loading

elaihau commented Jan 28, 2019

elaihau commented Jan 30, 2019

elaihau commented Jan 31, 2019

akosyakov commented Jan 31, 2019 • edited Loading

elaihau commented Jan 31, 2019

akosyakov Feb 1, 2019

Choose a reason for hiding this comment

elaihau Feb 1, 2019

Choose a reason for hiding this comment

akosyakov commented Feb 1, 2019

svenefftinge left a comment

Choose a reason for hiding this comment

elaihau commented Feb 1, 2019

elaihau commented Feb 4, 2019

elaihau commented Oct 22, 2018 •

edited

Loading

akosyakov commented Nov 5, 2018 •

edited

Loading

elaihau commented Nov 5, 2018 •

edited

Loading

akosyakov commented Jan 28, 2019 •

edited

Loading

akosyakov commented Jan 31, 2019 •

edited

Loading