[plug-in] Add document.registerDocumentSymbolProvider API #3483
Conversation
azatsarynnyy
force-pushed
the
az/sym
branch
2 times, most recently
from
6d87ac2
to
ecc44ec
Compare
| @@ -299,3 +299,42 @@ export interface WorkspaceEdit { | |||
| edits: Array<ResourceTextEdit | ResourceFileEdit>; | |||
| rejectReason?: string; | |||
| } | |||
|
|
|||
| export enum SymbolKind { | |||
There was a problem hiding this comment.
hello, does it conflict with https://github.com/theia-ide/theia/blob/b9d9bba4bf1ad1bccde86b02230f4b143be7d189/packages/plugin-ext/src/plugin/types-impl.ts#L1101 ? (like removing one or the other)
There was a problem hiding this comment.
@benoitf I'm not sure whether it's a good idea.
If I understand correctly, the model.ts is an API for main<->ext communication. But the types-impl.ts contains the types for using by the plugins. Correct me if I'm wrong, please.
Is it ok to depend one on another?
There was a problem hiding this comment.
@azatsarynnyy You are right, types model.ts is for main<->ext communication. types-impl.ts contains implementation described in theia.d.ts
There was a problem hiding this comment.
Are there any objections to merging this PR?
|
@benoitf don't you mind to merge this PR? |
Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
|
rebased on master |
This PR replaces previously added mock for
document.registerDocumentSymbolProviderAPI with the implementation.Closes #3200
Sample plugin is here eclipse/che-theia-samples#16