-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce SCM Plugin-Api #4279
Introduce SCM Plugin-Api #4279
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,6 +40,9 @@ export interface Command { | |
* A category of this command. | ||
*/ | ||
category?: string; | ||
|
||
// tslint:disable-next-line:no-any | ||
props?: { [key: string]: any } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do we need this one? It would be good to keep scope of changes to git/scm/plugin extensions and don't touch other extensions. The PR is big already enough. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I need it to pass additional arguments e.g. group There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @vinokurig please revert it and downcast in scm extension |
||
} | ||
|
||
export namespace Command { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vinokurig, indeed. but why?
what's the reason to not show SCM?