Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not clear Task definition or scope unless execution changes #4304

Merged
merged 1 commit into from
Feb 13, 2019

Conversation

elaihau
Copy link
Contributor

@elaihau elaihau commented Feb 11, 2019

  • in the current Task class of the plugin-ext package, the "definition" and "scope" property are reset if any Task property gets updated. Since the "task definition" is only dependent on "task execution", this change updates the value of "task definition" if and only if "task execution" is changed.

Signed-off-by: elaihau liang.huang@ericsson.com

@elaihau
Copy link
Contributor Author

elaihau commented Feb 11, 2019

- in the current Task class of the plugin-ext package, the "definition" and "scope" property are reset if any Task property gets updated. Since the "task definition" is only dependent on "task execution", this change updates the value of "task definition" if and only if "task execution" is changed.

Signed-off-by: elaihau <liang.huang@ericsson.com>
@elaihau elaihau merged commit c79be15 into eclipse-theia:master Feb 13, 2019
@elaihau elaihau deleted the task_constructor branch February 13, 2019 14:02
@elaihau
Copy link
Contributor Author

elaihau commented Feb 13, 2019

merged as the initial commit of #4216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants