support ignored globs & limit in file search & plugin-ext #4428
Conversation
elaihau
force-pushed
the
search_ignore
branch
from
f57cb98
to
6e54f3c
Compare
elaihau
force-pushed
the
search_ignore
branch
from
6e54f3c
to
9f6c5ac
Compare
- in current Theia, passing "ignored globs" or "limit" to plugins-api from plugins does not work, as the data is dropped before reaching the file search service. This change ensures the data goes through and handled by the service. Signed-off-by: elaihau <liang.huang@ericsson.com>
- vscode.workspace.findFiles() supports passing either a GlobPattern, undefined, or null to represent the pattern to ignore, while in theia, passing null is not allowed. This change aligned the theia pplugin api with that of vscode. Signed-off-by: elaihau <liang.huang@ericsson.com>
elaihau
force-pushed
the
search_ignore
branch
from
9f6c5ac
to
2f4c9d9
Compare
| it('should ignore globs passed through the search options', async () => { | ||
| const rootUri = FileUri.create(path.resolve(__dirname, '../../test-resources/subdir1/sub2')).toString(); | ||
|
|
||
| const matches = await service.find('**/*oo.*', { rootUris: [rootUri], defaultIgnorePatterns: ['*fo*'] }); |
There was a problem hiding this comment.
I tried changing the ignore pattern in the test, also was using rootUris: ['../../test-resources'], and there are some cases that I don't understand:
When I user defaultIgnorePatterns: ['f'] the search for **/*oo.* works.
Same with 'x' and '.' and 't'. Anything that is partially in one of the files work.
'z' doesn't ignore anything, so we get results back which fail the test, so that's good I guess.
Am I just confused?
There was a problem hiding this comment.
you are absolutely right. the client can define one or more string or glob in defaultIgnorePatterns. when you put 'z' in defaultIgnorePatterns, no files are matched and the function should return you foo.txt.
when you were using rootUris: ['../../test-resources'], please note that riggrep does not behave consistently with the patterns defined in .gitignore: BurntSushi/ripgrep#829. Jacques and I found even more scenarios where it failed to apply the rules defined in ignore files.
That's why I changed tests to find files from a folder where .gitignore does not exist :)
|
related to #4216 |
Signed-off-by: elaihau liang.huang@ericsson.com
Signed-off-by: elaihau liang.huang@ericsson.com