Involve selection service in tree view on plugin side #4609
Conversation
vzhukovs
added
plug-in system
| if (is(selection)) { | ||
| return selection.metadata; | ||
| } | ||
| if (Array.isArray(selection) && is(selection[0])) { |
There was a problem hiding this comment.
Does VS Code allow multi selection in contributed tree views?
There was a problem hiding this comment.
Have no idea, looking for it now. But meantime, we're allowing to create tree widgets that allow use multi selection. (via tree properties)
There was a problem hiding this comment.
Just checked, that they allow, but in the context menu only the last touched node is provided
There was a problem hiding this comment.
we're allowing to create tree widgets that allow use multi selection. (via tree properties)
I cannot find it. For me multi-selection in the tree widget does not work in Theia, but in VS Code does. I check with Node Dependencies tree from here: https://github.com/akosyakov/vscode-trees (you need this PR, otherwise samples does not work) Could it be that multi-selection should be enabled by default?
There was a problem hiding this comment.
I'm not 100% sure about it, but I made this conclusion based on this property, which pass into tree widget constructor here, this just need to be checked.
Could it be that multi-selection should be enabled by default?
I think it depends on configuration for particular use case. For example in kubernetes plugin there is a single selection option, but in file navigator a multi selection enabled. So I think, that multi selection might be enabled by default.
|
@vzhukovskii Do you have simple VS Code extension to run against Theia and VS Code and see that expectations match? Otherwise it is not possible to verify correctness. |
There was a problem hiding this comment.
I've just tested it with the Kubernetes extension.
Works well for the commands that rely on node's metadata.
To resolve the #3882 completely we also need to fix that issue for the commands that use a node object itself.
|
@azatsarynnyy Cool! Found this sample extension: https://github.com/Microsoft/vscode-extension-samples/tree/master/tree-view-sample checking that events are fired similarly with it... |
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
This proposal changes provides an ability to use selection service in tree widget, which constructs on the plugin side.
The problem appears in mechanism that delegates calls of the context menu items into calls of commands in command service. The problem was in that, in selection service the last selected file resource was stored and when we want to call a command from the context menu on tree, provided from plugin, we couldn't pass currently selected node as an argument into actual plugin.
Such problem was related with kubernetes plugin, where tree node should have a metadata information about object that displayed in the tree(cluster configuration, resources, attributes etc). Such metadata is used to controlling the kubernetes cluster.
Related issue: #3882
Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com