Promise.reject uses an Error instead of a string #4684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theBadT
force-pushed
the
4560-reject-promise
branch
from
bd5c4d1
to
de974e1
Compare
kittaakos
suggested changes
Mar 25, 2019
theBadT
force-pushed
the
4560-reject-promise
branch
from
e50a760
to
49d06b9
Compare
Signed-off-by: Thomas Drosdzoll <thomas.drosdzoll@gmx.net> added new to Error instation
theBadT
force-pushed
the
4560-reject-promise
branch
from
9357204
to
116b3f4
Compare
kittaakos
approved these changes
Mar 26, 2019
kittaakos
referenced
this pull request
Apr 17, 2020
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4560