Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create problem markers from task output #5024

Merged
merged 2 commits into from
Jul 9, 2019
Merged

create problem markers from task output #5024

merged 2 commits into from
Jul 9, 2019

Commits on Jul 9, 2019

  1. create problem markers from task output 

    What's included in this PR:
- support taskDefinition, problemMatcher, & problemPattern contributed by Theia plugins.
- support customizing tasks by adding named & anonymous problem matchers and patterns in .theia/tasks.json.
- support parsing output from both "start - finish" tasks and "watch" tasks.
- support both single line and multi line patterns.
- create problem markers on parsing task output with the plugin-defined or user-defined problem matchers and patterns.

What's not included:
- prompt users to provide problem matcher and / or patterns before starting tasks
- remove problem markers automatically when problems are fixed

CQ:
https://dev.eclipse.org/ipzilla/show_bug.cgi?id=19787. Approved on June 4 2019.
https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20139. Approved on June 11 2019.

Signed-off-by: elaihau <liang.huang@ericsson.com>
    elaihau committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    b2325ec View commit details
    Browse the repository at this point in the history

  2. dispose task listeners and emitters when needed 

    Signed-off-by: elaihau <liang.huang@ericsson.com>
    elaihau committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    3d9cc0f View commit details
    Browse the repository at this point in the history