Add 'reject-cycles' lerna option

[evidolob]

Now we have cyclic dependency problem
@theia/plugin-ext, @theia/scm depends on each other, and lerna provides this warning message:
Encountered a cycle in the dependency graph.This may cause instability! Packages in cycle are: "@theia/git", "@theia/plugin-ext-vscode", "@theia/plugin-ext", "@theia/scm", "@theia/example-browser", "@theia/example-electron"

This pull add --reject-cycles lerna option to fail build if any cyclic dependency exists

[kittaakos]

@evidolob, perhaps you forgot to commit the actual fix. Is this in a WIP state?

[evidolob]

No, I think @vinokurig is working on providing fix. I just wont to make sure that problem with cyclic dependencies never appears again.

[kittaakos]

I just wont to make sure that problem with cyclic dependencies never appears again.

I think we can all agree, we won't merge your PR without the fix :)

[evidolob]

Yes, of course

[vinokurig]

@evidolob @kittaakos I am working on it right now

[vinokurig]

@evidolob @kittaakos The Fix is ready, please review #5241

[kittaakos]

Can you please rebase from the master, @evidolob? The builds should pass with the fix.

[evidolob]

Done

[kittaakos]

Done

👍

Let's wait with the merge. See: #4279 (comment)

[vince-fugnitto]

Will the PR also pick this cyclic dependency? #4895

[kittaakos]

Will the PR also pick this cyclic dependency?

No. It checks npm package dependencies and cycles and not module dependencies.

[evidolob]

@kittaakos Hi, it seems that #5241 are merged, can you review this pull?

[kittaakos]

@evidolob, AFAIK, @akosyakov will go through the SCM-related changes manually and will check what functionality and commits did we lose. I'd leave the decision up to him.

[evidolob]

@kittaakos OK, thx. @akosyakov Any objections to merge this pull?

[akosyakov]

Could we enable it lerna.json instead, i.e. rejectCycles: true? that it works always

[evidolob]

I try to add it in lerna.json first, but lerna wasn't work. I found reject-cycles parameter there https://github.com/lerna/lerna/tree/master/core/global-options#--reject-cycles It seems that it's only command line option.

[akosyakov]

ok, thx