Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify scm/git data flow #5339

Closed
wants to merge 1 commit into from
Closed

Simplify scm/git data flow #5339

wants to merge 1 commit into from

Conversation

vinokurig
Copy link
Contributor

fixes #5295

@vinokurig vinokurig requested a review from akosyakov June 3, 2019 07:16
@vinokurig vinokurig mentioned this pull request Jun 3, 2019
Closed
@akosyakov
Copy link
Member

akosyakov commented Jun 3, 2019 •
edited
Loading

  • GitRepositoryProvider apis should be preserved, it is used a lot by extenders
  • SCM providers which are not contributed by git extension should be ignored, i.e. if not git extension provider is selected then it should be considered as not selected

akosyakov
akosyakov reviewed Jun 3, 2019
View reviewed changes
packages/git/src/browser/git-repository-provider.ts
@@ -71,9 +73,7 @@ export class GitRepositoryProvider {
this.lazyRefresh();
});

this._selectedRepository = await this.storageService.getData<Repository | undefined>(this.selectedRepoStorageKey);
Copy link
Member

@akosyakov akosyakov Jun 3, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove it? It is done that git does not show empty UI before actual state is loaded.

It could be good idea to implement it in SCM generically.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ScmRepository is a class, so it won't be serialized in the StorageService

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we jsonize scmrepositor data and recover classes on reload from such data?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ScmRepository consumes handlers: https://github.com/theia-ide/theia/blob/71f277be8505b8e405e945854e07edc6c12f1200/packages/scm/src/browser/scm-service.ts#L201 that are not serialized

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, will have a look what can be done

@vinokurig
Copy link
Contributor Author

@akosyakov

GitRepositoryProvider apis should be preserved, it is used a lot by extenders
SCM providers which are not contributed by git extension should be ignored, i.e. if not git extension provider is selected then it should be considered as not selected

Done

@vinokurig
Simplify scm/git data flow
1026a91 
Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
@akosyakov
Copy link
Member

@vinokurig I will merge your commits in a new PR and fix new issues (#5374, #5375) on the top.

@akosyakov akosyakov closed this Jun 11, 2019
@vinokurig vinokurig deleted the refactorScm branch July 8, 2019 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akosyakov akosyakov akosyakov left review comments

@benoitf benoitf Awaiting requested review from benoitf

@evidolob evidolob Awaiting requested review from evidolob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

simplify scm/git data flow
2 participants
@vinokurig @akosyakov