Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #5732, #5735: fixed box-shadow and background-color in quick-open menu #5733

Merged
merged 2 commits into from
Jul 23, 2019
Merged

Fixed #5732, #5735: fixed box-shadow and background-color in quick-open menu #5733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69a9506
Fixed #5732: fixed `box-shadow` in quick-open menu to support dark theme
Jul 16, 2019
1ad6186
Fixed #5735: aligned background color of quick-open menu with other w…
Jul 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/core/src/browser/style/scrollbars.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,3 +172,7 @@
.monaco-scrollable-element > .scrollbar.horizontal > .slider {
height: var(--theia-scrollbar-width) !important;
}

.monaco-scrollable-element > .shadow.top {
box-shadow: var(--theia-scrollbar-box-shadow-color) 0px 6px 6px -6px inset !important;
}
1 change: 1 addition & 0 deletions packages/core/src/browser/style/variables-bright.useable.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ is not optimized for dense, information rich UIs.
--theia-scrollbar-rail-color: transparent;
--theia-scrollbar-active-thumb-color: hsla(0,0%,39%,.4);
--theia-scrollbar-active-rail-color: transparent;
--theia-scrollbar-box-shadow-color: #DDD;

/* Menu */
--theia-menu-color0: var(--theia-layout-color3);
Expand Down
1 change: 1 addition & 0 deletions packages/core/src/browser/style/variables-dark.useable.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ is not optimized for dense, information rich UIs.
--theia-scrollbar-rail-color: transparent;
--theia-scrollbar-active-thumb-color: hsla(0,0%,61%,.4);
--theia-scrollbar-active-rail-color: transparent;
--theia-scrollbar-box-shadow-color: #000;

/* Menu */
--theia-menu-color0: var(--theia-layout-color4);
Expand Down
4 changes: 4 additions & 0 deletions packages/monaco/src/browser/style/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@
margin-right: 0px;
}

.monaco-quick-open-widget {
background-color: var(--theia-layout-color1) !important;
}

.quick-open-entry .quick-open-row .monaco-icon-label .monaco-icon-label-description-container .monaco-highlighted-label .highlight {
color: var(--theia-accent-color1);
}
Expand Down