Fix the type and initial value of 'editor.quickSuggestions', fix #5227 #5228

[BroKun]

Signed-off-by: Brokun brokun0128@gmail.com

What it does

Fix the type and initial value of 'editor.quickSuggestions', suggestions won't be seen by default in string and comment.

How to test

Modifying preferences, we can now control whether suggestions should be displayed in comments and strings.

[vince-fugnitto]

@BroKun I tested against both issues #5227 and #5228
Is this the expected behavior by default?

#5227: annoying auto-suggestion when writing comments

#5228: incorrect auto-suggestion when writing strings

[BroKun]

@vince-fugnitto In addition to the quickSuggestion, there are triggerCharacters to trigger suggestions, as is the case in your GIF. In this case, we are still not the same as VS Code, I will look at how to deal with it.

[akosyakov]

@vince-fugnitto @BroKun is there something left to do to land this PR?

[vince-fugnitto]

@vince-fugnitto @BroKun is there something left to do to land this PR?

When testing it wasn't working for me (see GIFs), unless I turned off editor.suggestOnTriggerCharacters which I don't think is a viable workaround.

[BroKun]

@vince-fugnitto @BroKun is there something left to do to land this PR?

I think this work is now compelete, but I noticed that there is a commit that is duplicated with another #5931 . Should I handle some my commit based on another PR ?

[akosyakov]

@BroKun let's wait till #5931 is merged, then you can rebase and then we merge it
@vince-fugnitto Could you give it a try please?

[akosyakov]

@BroKun Could you rebase it please?

[BroKun]

@akosyakov After monaco upgraded to 0.17.0, these configurations have all been migrated. Let's close this PR.