Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #5229: Add language configuration items for js, ts and jsx #5976

Merged
merged 1 commit into from
Sep 29, 2019

Conversation

BroKun
Copy link
Member

@BroKun BroKun commented Aug 18, 2019

Signed-off-by: Brokun brokun0128@gmail.com

What it does

Added some configuration items that only exist in vscode, some may not be used yet.
There are still some differences, we can handle them when we upgrade the editor.

How to test

Type a multi-line comment, and the enter key will bring the right code.

@akosyakov
Copy link
Member

@BroKun Just to check: now it is aligned with VS Code right? it is important to have the same, since in future we want to consume them directly from VS Code built-in extensions. Please provide links for copied code 🙏

The best would be if you file a CQ following this process: https://github.com/theia-ide/theia/wiki/Registering-CQs#codecontent-is-copied-from-other-projectsrepos If it is too involving please ping @theia-ide/ip-help for help.

@akosyakov akosyakov added the textmate issues related to the textmate grammars label Aug 18, 2019
@vince-fugnitto
Copy link
Member

Hi @BroKun, just wanted to know if you had any update on the PR, or if you needed help :)

…nd jsx

Signed-off-by: Brokun <brokun0128@gmail.com>
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works correctly for me, I now see block comments correctly:
Example:

/**
 * 
 * 
 */
const a = 10;

I understand the only thing left to do is register and wait for a CQ?

@BroKun
Copy link
Member Author

BroKun commented Sep 29, 2019

@vince-fugnitto the CQ has been approved, let's merge it.

@svenefftinge svenefftinge merged commit 528f1a0 into eclipse-theia:master Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
textmate issues related to the textmate grammars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants