-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[plugin] Implement SCM Repository selected event #6150
Conversation
abbdff7
to
db72562
Compare
@vinokurig I could not figure out how I can test that a source control is properly unselected with the proposed extension. We need an extensions which has several source controls and show notifications when one get unselected or selected. |
db72562
to
219425b
Compare
@akosyakov I think I've understood your point, I've reworked the logic and now you can test this against the plugin provided above that I've changed as well. To apply the plugin you need to disable built in Git extension and paste any folder paths as a repository url: https://github.com/vinokurig/Test/blob/2f48915bab1487d5998ceed06c68d60c898f5ffc/src/scm-plugin-backend.ts#L9-L11 |
@vinokurig it looks better now! but i don't see initial notification and after i switch to another repo there is no notification that an initial repository is unselected. |
219425b
to
a286171
Compare
I've fixed that by extracting the logic to a method as you recommended. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it works very nice now!
@vinokurig please rebase and if ci is green please merge, don't forget to address the outstanding comments |
3dea264
to
c7b5a19
Compare
Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
c7b5a19
to
fbca122
Compare
What it does
Implement SCM Repository selected event: https://github.com/microsoft/vscode/blob/a50cf110d96fbe50fc460a6de14ade5b6b060dd4/src/vs/vscode.proposed.d.ts#L673-L684
Removed duplicated
SourceControlResourceDecorations
interface.How to test
/
SCM repository (this is a view of a dummy SCM repository):See the notification that is fired inside the event handler.
Select other repository again.
See the notification that the repository is NOT selected.
Review checklist
Reminder for reviewers