Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] replace AppVeyor with Travis CI for Windows #6179

Merged
merged 1 commit into from
Sep 13, 2019
Merged

Conversation

vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Sep 12, 2019

What it does

Fixes #6176

  • Removed appveyor.yml file
  • Replaced the appveyor.yml file with new windows sections in the .travis.yml file

How to test

Verify that the CI works correctly for Linux, macOS and Windows

Review checklist

Reminder for reviewers

Signed-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com

@vince-fugnitto vince-fugnitto added ci issues related to CI / tests proposal feature proposals (potential future features) labels Sep 12, 2019
@vince-fugnitto vince-fugnitto self-assigned this Sep 12, 2019
@marcdumais-work
Copy link
Contributor

You could as well remove the AppVeyor build status badge near the top of the README,

Fixes #6176

- Removed `appveyor.yml` file
- Replaced the `appveyor.yml` file with new windows sections in the `.travis.yml` file

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's cool! i'm for dropping additional configs and services

Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, I wasn't aware Travis-CI supports Windows nodes as well.

Do not we have to do something with Appveyor or do these checks go away once we merge the PR?

Screen Shot 2019-09-13 at 08 44 44

Copy link
Member

@thegecko thegecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcdumais-work
Copy link
Contributor

Do not we have to do something with Appveyor or do these checks go away once we merge the PR?

Indeed - this will be through a request to Webmaster to remove the AppVeyor integration / webhook(s) from the repo's config. We still have an open bugzilla where I can do so.

@marcdumais-work marcdumais-work merged commit 1c0fe3d into master Sep 13, 2019
@marcdumais-work marcdumais-work deleted the vf/GH-6176 branch September 13, 2019 10:26
@marcdumais-work
Copy link
Contributor

this will be through a request to Webmaster to remove the AppVeyor integration / webhook(s) from the repo's config. We still have an open bugzilla where I can do so.

This has been done; no more AppVeyor entry in this re-triggered PR CI: #6180

vince-fugnitto added a commit to vince-fugnitto/theia-website that referenced this pull request Oct 8, 2019
Fixes eclipse-theia#63

Description:

- Remove the reference and badge to `AppVeyor` since
the CI integration no longer exists in the main repository as
of eclipse-theia/theia#6179.

Additional Info

- The badge displayed an old build which was failing meaning
the failed state would always be displayed unless the badge
is removed.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci issues related to CI / tests proposal feature proposals (potential future features)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] enable Travis CI on Windows
5 participants