-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] replace AppVeyor with Travis CI for Windows #6179
Conversation
You could as well remove the AppVeyor build status badge near the top of the README, |
2fa8324
to
70b011e
Compare
Fixes #6176 - Removed `appveyor.yml` file - Replaced the `appveyor.yml` file with new windows sections in the `.travis.yml` file Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
70b011e
to
fc18a45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's cool! i'm for dropping additional configs and services
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Indeed - this will be through a request to Webmaster to remove the AppVeyor integration / webhook(s) from the repo's config. We still have an open bugzilla where I can do so. |
This has been done; no more AppVeyor entry in this re-triggered PR CI: #6180 |
Fixes eclipse-theia#63 Description: - Remove the reference and badge to `AppVeyor` since the CI integration no longer exists in the main repository as of eclipse-theia/theia#6179. Additional Info - The badge displayed an old build which was failing meaning the failed state would always be displayed unless the badge is removed. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
What it does
Fixes #6176
appveyor.yml
fileappveyor.yml
file with new windows sections in the.travis.yml
fileHow to test
Verify that the CI works correctly for
Linux
,macOS
andWindows
Review checklist
Reminder for reviewers
Signed-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com