-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #5659, Unify the icon color settings for Menu and Toolbar, and fixed some strange places #6199
Conversation
Signed-off-by: Brokun <brokun0128@gmail.com>
These are very good improvements. Thank you! |
Signed-off-by: Brokun <brokun0128@gmail.com>
Signed-off-by: Brokun <brokun0128@gmail.com>
- Use pointer cursor when replace-all button is available. - Search-detail and search-header are horizontally aligned. - Use absolute position to make the clickable area of the toggle button larger. Signed-off-by: Brokun <brokun0128@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code changes looks good to me, please rely on @jbicker's approve for testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too!
@BroKun please merge |
What it does
fix #5659
How to test
Review checklist
Reminder for reviewers