[plugin] wait for workspace to be ready #6248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
svenefftinge
changed the title
|
I think we should merge it that VS Code extensions are initialized with the workspace specific storage path, but java extension is actually handling the case when |
akosyakov
approved these changes
Sep 24, 2019
svenefftinge
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Awaits for workspace service to be initialized before computing the storage path for plugins.
With slow workspace initialization sometime the first call to storage path resolved to
undefined.As a result plugins get loaded and activated with a bad storage path and fail.
How to test
Deploy redhat-vscode java extension and make workspace initialization slow (or block though breakpoint). See how the extension fails on activate becasue it tries to create directory withinn the storagePath.
Review checklist
Reminder for reviewers