Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[quick-open] Do not validate input on start #6281

Merged
merged 1 commit into from
Oct 2, 2019
Merged

[quick-open] Do not validate input on start #6281

merged 1 commit into from
Oct 2, 2019

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Sep 27, 2019

What it does

Check if the onType handler is fired at first time, ignore validating the input. As QuickInputService wraps QuickOpenServece:


such workaround can resolve the problem.
fixes #6245

How to test

  1. Clone and compile the test plugin
  2. Start the plugin as a Hosted Plugin
  3. F1 => Hello World

See: The validation is not called on the start.

Review checklist

Reminder for reviewers

Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
@vinokurig vinokurig added the quick-open issues related to the quick-open label Sep 27, 2019
Copy link
Contributor

@JPinkney JPinkney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akosyakov
Copy link
Member

@vinokurig Does it close any issues? Could you reference them please?

@vinokurig
Copy link
Contributor Author

@akosyakov

Does it close any issues? Could you reference them please?

Updated description.

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works nicely for me too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quick-open issues related to the quick-open
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[quick open] Quick input validation handler fires on widget start
3 participants