fix command execution for inline editors #6328
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Since migrating to Monaco 0.18 we handle monaco keybindings to avoid some bugs, like inability to close the reference widget. It led to a regression for inline editors, since they are not tracked by editor managers.
This PR tracks the last focused Monaco editor regardless whether it is inline or not and apply Monaco commands to it.
How to test
Review checklist
Reminder for reviewers