Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix command execution for inline editors #6328

Merged
merged 1 commit into from
Oct 4, 2019
Merged

fix command execution for inline editors #6328

merged 1 commit into from
Oct 4, 2019

Conversation

akosyakov
Copy link
Member

What it does

Since migrating to Monaco 0.18 we handle monaco keybindings to avoid some bugs, like inability to close the reference widget. It led to a regression for inline editors, since they are not tracked by editor managers.

This PR tracks the last focused Monaco editor regardless whether it is inline or not and apply Monaco commands to it.

How to test

  • Use inline editors, like input in the debug console and breakpoint expression editor, and make sure that keys applied to them when they are focused.
  • Check that there is no regressions for editors widgets by typing and using features as content assist and find references.

Review checklist

Reminder for reviewers

Since migrating to Monaco 0.18 we handle monaco keybindings to avoid some bugs, like inability to close the reference widget. It led to a regression for inline editors, since they are not tracked by editor managers.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov added debug issues that related to debug functionality monaco issues related to monaco labels Oct 4, 2019
Copy link
Contributor

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well

@akosyakov akosyakov merged commit ee4cbce into master Oct 4, 2019
@akosyakov akosyakov deleted the GH-6325 branch October 4, 2019 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug issues that related to debug functionality monaco issues related to monaco
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enter is not working in debug console
2 participants