-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support input variables for tasks #6331
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -150,6 +150,7 @@ export namespace VariableResolverService { | |
} catch (e) { | ||
console.error(`Failed to resolved '${name}' variable`, e); | ||
this.resolved.set(name, undefined); | ||
throw e; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @elaihau could you elaborate why? It is a breaking change, before broken variables will computed as undefined, but the entire operation won't be stopped. It affects not only tasks but also launch configurations. We should test this changes agains the debug extension before merging this PR. |
||
} | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elaihau please revert all changes to resolver
I see what you want now, but we should do it holistically and fix in all other places. Please file an issue for it