-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support "group" in the task config #6522
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general everything works great :)
A few things I noticed:
- when configuring the default build task through the menu item, I think we should open the
tasks.json
as well like VS Code - when configuring the default test task through the menu item, I think we should open the
tasks.json
as well like VS Code - if a workspace has no tasks present, should we add better user feedback when they try and execute
run build task
andrun test task
? (perhaps similarly asrun task
displayno tasks found
)
af337b6
to
3c2ef1e
Compare
Thank you for the review @vince-fugnitto ! |
See you soon! 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a follow-up issue which I think we can improve in the future: #6525
I noticed one discrepancy between our implementation and VS Code.
Do we want to cover it during this PR or as an enhancement later?
Scenario
- Configure two different tasks as the default
build
tasks- Theia: executes the first default
build task
- VS Code: prompts users to select the
build
task
- Theia: executes the first default
- With this change users would be able to define and run build tasks, test tasks, default build tasks, and default test tasks. - resolves #6144 Signed-off-by: Liang Huang <liang.huang@ericsson.com>
3c2ef1e
to
94e2122
Compare
I resolved the issue where multiple default build/test tasks are defined in the config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works correctly for me 😄
Thank you for making the adjustments!
test tasks, default build tasks, and default test tasks.
Signed-off-by: Liang Huang liang.huang@ericsson.com
How to test
Use case 1:
"group": "build"
to task configs intasks.json
Use case 2:
Review checklist
as an author, I have thoroughly tested my changes and carefully followed the review guidelines
Approval of CQ https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20967