Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tasks] prompt users to configure tasks #6539

Merged
merged 1 commit into from
Nov 13, 2019
Merged

[tasks] prompt users to configure tasks #6539

merged 1 commit into from
Nov 13, 2019

Conversation

vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Nov 12, 2019

What it does

Fixes #6525
Fixes #1017

  • adjust the run task to display an item which prompts users to configure tasks when
    no tasks are currently available.
  • adjusts the run build task to display an item which prompts users to configure tasks when no tasks are currently available.
  • adjusts the run test task to display an item which prompts users to configure tasks when no tasks are currently available.

How to test

  1. open a workspace without any tasks
  2. attempt to run task (users should be prompted to configure a task)
  3. attempt to run build task (users should be prompted to configure a task)
  4. attempt to run test task (users should be prompted to configure a task)
  5. open a workspace with tasks
  6. task execution for (run task, run build task, and run test task should work as before)

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

@vince-fugnitto vince-fugnitto added enhancement issues that are enhancements to current functionality - nice to haves tasks issues related to the task system labels Nov 12, 2019
@vince-fugnitto vince-fugnitto self-assigned this Nov 12, 2019
Fixes #6525
Fixes #1017

- adjust the `run task` to display an item which prompts users to configure tasks when
no tasks are currently available.
- adjusts the `run build task` to display an item which prompts users to configure
tasks when no tasks are currently available.
- adjusts the `run test task` to display an item which prompts users to configure
tasks when no tasks are currently available.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
Copy link
Contributor

@elaihau elaihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested in a single and a multi root workspace.

I confirm the run task, run build task, and run test task all work as expected.

Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works as described. Good to see it aligned with VS Code.

Copy link
Contributor

@RomanNikitenko RomanNikitenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested single and a multi root workspace.
Works well for me!

@vince-fugnitto
Copy link
Member Author

Thank you @elaihau @azatsarynnyy @RomanNikitenko !

@vince-fugnitto vince-fugnitto merged commit 27cba60 into master Nov 13, 2019
@vince-fugnitto vince-fugnitto deleted the vf/GH-6525 branch November 13, 2019 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves tasks issues related to the task system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[task] prompt users to create tasks from templates [Tasks] Add Command to create and open tasks.json
4 participants