-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tasks] prompt users to configure tasks #6539
Conversation
8fc7da0
to
a978195
Compare
Fixes #6525 Fixes #1017 - adjust the `run task` to display an item which prompts users to configure tasks when no tasks are currently available. - adjusts the `run build task` to display an item which prompts users to configure tasks when no tasks are currently available. - adjusts the `run test task` to display an item which prompts users to configure tasks when no tasks are currently available. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
a978195
to
6c27d24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested in a single and a multi root workspace.
I confirm the run task
, run build task
, and run test task
all work as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works as described. Good to see it aligned with VS Code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested single and a multi root workspace.
Works well for me!
Thank you @elaihau @azatsarynnyy @RomanNikitenko ! |
What it does
Fixes #6525
Fixes #1017
run task
to display an item which prompts users to configure tasks whenno tasks are currently available.
run build task
to display an item which prompts users to configure tasks when no tasks are currently available.run test task
to display an item which prompts users to configure tasks when no tasks are currently available.How to test
run task
(users should be prompted to configure a task)run build task
(users should be prompted to configure a task)run test task
(users should be prompted to configure a task)run task
,run build task
, andrun test task
should work as before)Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com