Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to use upload service on plugin side #6554

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Add ability to use upload service on plugin side #6554

merged 1 commit into from
Nov 22, 2019

Conversation

vzhukovs
Copy link
Contributor

@vzhukovs vzhukovs commented Nov 15, 2019 •
edited
Loading

What it does

This changes proposal adds an ability to call upload service from plugin side.

Real world example of usage this api in che-theia. This sample shows how user can upload private ssh key from plugin:
upload_ssh_key

Linked issue in che-theia: eclipse-che/che-theia#547

Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com

How to test

Clone this example into plugins folder. After theia and plugin build run theia and call action Upload File.

Review checklist

Reminder for reviewers

@vzhukovs vzhukovs added enhancement issues that are enhancements to current functionality - nice to haves plug-in system issues related to the plug-in system Team: Che-Plugins issues related to the che-plugins team labels Nov 15, 2019
@vzhukovs vzhukovs self-assigned this Nov 15, 2019
@vzhukovs vzhukovs mentioned this pull request Nov 15, 2019
Merged
azatsarynnyy
azatsarynnyy approved these changes Nov 15, 2019
View reviewed changes
Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it with the proposed example. Works well!

@vzhukovs
Add ability to use upload service on plugin side
754f8f1 
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
vinokurig
vinokurig approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@vinokurig vinokurig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the plugin, works nice!

@vparfonov
Copy link
Contributor

@akosyakov can you review please

@akosyakov
Copy link
Member

@vparfonov please merge it, i will comment if i see something suspicious, PRs was approved for enough time that everybody could have a look at it

@vzhukovs vzhukovs merged commit d5ca4f6 into master Nov 22, 2019
@vzhukovs vzhukovs deleted the che#14911 branch November 22, 2019 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinokurig vinokurig vinokurig approved these changes

@azatsarynnyy azatsarynnyy azatsarynnyy approved these changes

@evidolob evidolob Awaiting requested review from evidolob

@vparfonov vparfonov Awaiting requested review from vparfonov

@akosyakov akosyakov Awaiting requested review from akosyakov

@benoitf benoitf Awaiting requested review from benoitf

Assignees

@vzhukovs vzhukovs

Labels
enhancement issues that are enhancements to current functionality - nice to haves plug-in system issues related to the plug-in system Team: Che-Plugins issues related to the che-plugins team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vzhukovs @vparfonov @akosyakov @azatsarynnyy @vinokurig