-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated dugite-extra
and find-git-exec
.
#6602
Conversation
The updated dependencies contain fix for: - The termination of the spawned process. The bogus process termination resulted in an empty string from the `stdout` as the `exec-path`. The empty string "path" was incorrectly normalized to `.`. (See: #6587) - [win32]: Enhanced `git` discovery. The new logic falls back to `which`. - [win32]: The unstaging command. `-u` was added to ensure that git's index reflects a consistent view of the working tree after the operation has been performed. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Tested with docker/linux environment in Gitpod. Works nicely! Thank you very much for taking care of this fixes! 🙏
(Would be nice, if some else verify this on Windows.)
I will. |
I have verified the unstaging on Windows. It worked. The not on PATH defect was never an issue with my Windows env. I am merging it. |
Checking now, thanks for your patience :) update: I see the PR is merged, but I'll check anyway |
@kittaakos Everything looks good:
|
Thank you for your help, @marcdumais-work! |
The updated dependencies contain fix for:
stdout
as theexec-path
. The empty string "path" was incorrectly normalized to.
. (See: useclose
notexit
process event #6587)git
discovery. The new logic falls back towhich
.-u
was added to ensure that git's index reflects a consistent view of the working tree after the operation has been performed.Signed-off-by: Akos Kitta kittaakos@typefox.io
What it does
See above 👆
How to test
Review checklist
Reminder for reviewers
@marcdumais-work, I would like to request you for a review becasue of the dependencies update. We maintain both dependencies, both have MIT license.
find-git-exec
was inspired by VS Code, but it was always the case. Please check if we are good with the PR. Thank you!