Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package name for libX11 for Red Hat based OS #6632

Merged
merged 1 commit into from
Nov 26, 2019

Conversation

apupier
Copy link
Contributor

@apupier apupier commented Nov 26, 2019

see https://rpmfind.net/linux/rpm2html/search.php?query=libx11-devel%28x86-64%29&submit=Search+...

Signed-off-by: Aurélien Pupier apupier@redhat.com

What it does

How to test

Review checklist

Reminder for reviewers

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I restarted the macOS build manually and it is passing :)
It looks fine to me, thank you!

@vince-fugnitto vince-fugnitto added the documentation issues related to documentation label Nov 26, 2019
@vince-fugnitto
Copy link
Member

@apupier do you need help to merge?

@benoitf benoitf merged commit 0f16fe8 into eclipse-theia:master Nov 26, 2019
@apupier
Copy link
Contributor Author

apupier commented Nov 27, 2019

do you need help to merge?

yes, I don't have rights to merge on this repo.

so thanks Florent :-)

@apupier apupier deleted the fixTypoPackageName branch November 27, 2019 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation issues related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants