Reorganize tasks when task schema is updated

[RomanNikitenko]

What it does

Rely on onDidChangeTaskSchema event to reorganize tasks configurations.
Fixes #6640

How to test

1. Use vs code extensions with tasks (like typescript, npm).
   Tasks should be available for running from Terminal -> Run task menu.
   Try to run them, configure and run, refresh page and run again.

2. Please use my forked repo for testing, it contains:

• the current PR changes
• the test extension which allows to add/remove schemes for custom types
• tasks with custom type for testing

1. git clone https://github.com/RomanNikitenko/theia.git
2. cd theia/ and git checkout reorganizeTasks.
3. Build the project and run it.
4. The project contains prepared tasks in tasks.json file, so please open the cloned project: File=>Open... and select the project.
5. Go to Terminal => Run Task menu:
   you can see that only SHELL task is available for running
6. Go to Help menu and select Add CHE task schema
   you can see that now CHE task is available for running as well as SHELL task.
7. Try the same for EXEC task
8. You can try to remove subschema for CHE task and EXEC task using Help menu
   you can see that the corresponding tasks are not available for running after that.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: Roman Nikitenko rnikiten@redhat.com

[elaihau]

from the functionality point of view the problem is fixed with this change. I will do one more round of testing after Anton's comment is addressed.

[elaihau]

I tested in the example browser with NPM extension and Roman's test extension. It worked well.

[akosyakov]

let's keep URI here, clients can do toString if it is required or check other properties

[akosyakov]

code-wise looks good me

@elaihau I have not actually tested, could you have a look please?

[elaihau]

dumb question for Roman:
This block of code shows that this.jsonSchemaStore.registerSchema() (in the catch block) is not always called.
that means, TaskSchemaUpdater.onDidChangeTaskSchemaEmitter wouldn't always fire when the schema gets updated. Is it OK?

[akosyakov]

@elaihau It will be fired from https://github.com/eclipse-theia/theia/pull/6643/files#diff-c34063f85d0ae9acca8b8841309dc4a1R55 whenever content of schema is updated.

[elaihau]

@elaihau It will be fired from https://github.com/eclipse-theia/theia/pull/6643/files#diff-c34063f85d0ae9acca8b8841309dc4a1R55 whenever content of schema is updated.

Got it. thank you for explaination. I have no more questions

[RomanNikitenko]

@akosyakov @elaihau
thank you very much for review and testing!

I'm going to merge the PR.