[core] don't scroll when closing a dialog #6674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a dialog gets closed, the previously active element gets focus again. We don't want the default scroll to top behavior. Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
vince-fugnitto
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a dialog gets closed, the previously
active element gets focus again. We don't
want the default scroll to top behavior.
How to test
Expand the navigator to a state where you scrolled down a bit.
Now right click and choose new file so the dialog appears.
Close the dialog the navigator should have focus again without scrolling to the top.
Review checklist
Reminder for reviewers