-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[statusbar] add misc statusbar tooltips #6770
Conversation
- added statusbar tooltip for `select language mode` - added statusbar tooltip for `select encoding` - added statusbar tooltip for `select indentation` - added statusbar tooltip for `select end of line sequence` - added statusbar tooltip for `go to line` (clicking the statusbar item now triggers the `go to line` command)` Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Comment: When I start in electron and there is already a file in the editor(settings.json) the status bar does not show the options to test, I need to open a new file or close + re-open a file to see the status bar options.
If possible, when the browser is full screen, The tooltip overlaps the status bar text, could it be possible to put the tooltip above the status bar in this case
Look at the code OK
Tested on Ubuntu only
It worked correctly for me, I see all available statusbar items even if an editor is currently opened on startup. Which statusbar item did you not see?
The tooltip is controlled by the browser and operating system. |
All of the items on the right side |
As we verified together, the contributed contributed statusbar items in question are only added when the editor itself has selection. If an editor does not have selection on startup, the statusbar items are not present which in this case is the observed behavior. Perhaps we can be smarter about when these items are created but I feel as though it is out of the scope of this particular pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it in Gitpod. Looks good. Thank you !
BTW, I don't see tooltip text for the status bar button for the |
Thanks! I actually covered it later in #6771 |
What it does
select language mode
select encoding
select indentation
select end of line sequence
go to line
(clicking the statusbar item now triggers thego to line
command)`How to test
go to line
statusbar item now triggers thego to line
commandReview checklist
Reminder for reviewers
Signed-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com