Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[git] update 'git checkout' statusbar tooltip #6779

Merged
merged 1 commit into from
Dec 23, 2019
Merged

Conversation

vince-fugnitto
Copy link
Member

What it does

Fixes #6765

Updates the statusbar tooltip for the Git Checkout... command, aligning the behavior with that present in VS Code. With this change, hovering over the statusbar item now displays the repo name, scm provider, the branch name and the state the branch is in (if the branch has unstaged, staged, and merged changes`).

How to test

  1. start the application with theia as a workspace

  2. hover over the branch name in the statusbar

  3. hovering should now display the repo name, scm provider, branch name, and state

    ex: theia (Git) - master+
    

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

Fixes #6765

- updates the tooltip for the `git checkout` statusbar tooltip aligning it with the value
present in VS Code. Now, the tooltip displays the current branch, as well as the status of the branch (`unstaged`, `staged`, `merged` changes)

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto added git issues related to git statusbar issues related to the statusbar labels Dec 20, 2019
@vince-fugnitto vince-fugnitto self-assigned this Dec 20, 2019
Copy link
Contributor

@lmcbout lmcbout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Code: ok
Test: Ubuntu with Chrome and Firefox: OK
Thanks @vince-fugnitto

Copy link
Contributor

@elaihau elaihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the status, i.e., +*!, in example browser, as I didn't even notice their existence in vs code.

Looks good to me. Thank you !

@vince-fugnitto
Copy link
Member Author

@lmcbout @elaihau
Thank you for the review, happy holidays! 🍾

@vince-fugnitto vince-fugnitto merged commit 25d0e2b into master Dec 23, 2019
@vince-fugnitto vince-fugnitto deleted the vf/GH-6765 branch December 23, 2019 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
git issues related to git statusbar issues related to the statusbar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[scm] inconsistent tooltip for reference checkout statusbar item
3 participants