Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped version of find-git-repositories #6850

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

federicobozzini
Copy link
Contributor

@federicobozzini federicobozzini commented Jan 8, 2020

Bumped version of find-git-repositories to version 0.1.1.

What it does

This should fix #6529.

How to test

To test, just run Theia on Windows.

Review checklist

Reminder for reviewers

Signed-off-by: Federico Bozzini <federico.bozzini@gmail.com>
@vince-fugnitto
Copy link
Member

I verified using ClearlyDefined and the dependency looks fine.
@marechal-p do you mind testing it quickly since you have a Windows machine?

@vince-fugnitto vince-fugnitto added the dependencies pull requests that update a dependency file label Jan 8, 2020
@akosyakov akosyakov added the electron issues related to the electron target label Jan 9, 2020
@akosyakov
Copy link
Member

@westbury maybe you can check whether it fixes #6529
@kittaakos is away now for another week at least

@paul-marechal
Copy link
Member

This change fixes #6529.

@akosyakov
Copy link
Member

@marechal-p ok, please approve if you tested

@westbury
Copy link
Contributor

westbury commented Jan 9, 2020

I have tested this on Windows, Electron and it does appear to fix the issue.

Also note that the only change between versions 0.1.0 and 0.1.1 of find-git-repositories is the flag change (it's not an active project).

@paul-marechal paul-marechal merged commit d74a18b into eclipse-theia:master Jan 9, 2020
@federicobozzini federicobozzini deleted the windows-fix branch January 10, 2020 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies pull requests that update a dependency file electron issues related to the electron target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Electron example not running in windows machine
5 participants