-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api integration tests #6852
api integration tests #6852
Conversation
485b1d5
to
5a3db5f
Compare
This PR already replaces old UI wdio test with API based tests which actually find timing issues with our APIs, memory leaks in react scm and git extensions and make shell API more complete. |
c9f0f1e
to
d1bb378
Compare
7ab3c06
to
3392f1d
Compare
bf1af24
to
89ce6d5
Compare
89ce6d5
to
33a16e4
Compare
b3e0c10
to
de694dc
Compare
de694dc
to
b7f5a71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty cool! Is it possible to write tests in typescript as well?
I suppose so, if it compiles to code which can be executed by chrome, keeps requires and does not need any 3rd party deps then it should work. I have not done it because ts-check became very good. The whole webpack repo for example checked with this without any compilation. But i can switch if you want. |
b7f5a71
to
224ecda
Compare
I'm merging if the build is green, will add more monaco tests in gitlens PR for newly exposed api. |
99209e4
to
b61b5f5
Compare
@eclipse-theia/ecd-theia-committers Travis does not seem to pick up my latest commits, does anyone know what can be done to trigger the build? |
Probably something is wrong with Travis ATM. I restarted the job that failed for the latest commit on master, and after a few minutes it's still in https://travis-ci.com/eclipse-theia/theia/jobs/278277336 update: it has started now. Maybe you can amend your top PR commit so the SHA changes and force-push: hopefully that will wake travis up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .travis file is broken :)
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
b61b5f5
to
2ec041b
Compare
What it does
New docs rendered:
fix #6409
theia test
to run tests--plugins
directly totheia test
command@theia/api-tests
How to test
yarn test
inexamples/browser
to run integration tests.yarn test:debug
inexamples/browser
to debug integration tests. A new chrome instance will be opened. Refresh to rerun tests andgrep
query param to filter tests.Review checklist
Reminder for reviewers