Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relaxed the log level for the navigation service #7042

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Jan 31, 2020

It is hard to see anything when starting the app in debug mode.
Clients are free to adjust the log level in the launch configs:
Use --log-level=trace.

Signed-off-by: Akos Kitta kittaakos@typefox.io

What it does

Reduced the default log level from debug to trace when updating the editor navigation history.

How to test

Start the app in debug mode, open one or more editors and change the cursor location. Check the logs, you should not see tons of this:

root DEBUG Registering new location: {"uri":"user_storage:settings.json","type":0,"context":{"line":5,"character":12}}.
root DEBUG The new location {"uri":"user_storage:settings.json","type":0,"context":{"line":5,"character":12}} is similar to the current one: {"uri":"user_storage:settings.json","type":1,"context":{"start":{"line":0,"character":0},"end":{"line":0,"character":0}}}. Aborting.
root DEBUG Registering new location: {"uri":"user_storage:settings.json","type":2,"context":{"range":{"start":{"line":5,"character":12},"end":{"line":5,"character":12}},"rangeLength":0,"text":"ô"}}.
root DEBUG The new location {"uri":"user_storage:settings.json","type":2,"context":{"range":{"start":{"line":5,"character":12},"end":{"line":5,"character":12}},"rangeLength":0,"text":"ô"}} is similar to the current one: {"uri":"user_storage:settings.json","type":1,"context":{"start":{"line":0,"character":0},"end":{"line":0,"character":0}}}. Aborting.
root DEBUG Registering new location: {"uri":"user_storage:settings.json","type":0,"context":{"line":5,"character":13}}.
root DEBUG The new location {"uri":"user_storage:settings.json","type":0,"context":{"line":5,"character":13}} is similar to the current one: {"uri":"user_storage:settings.json","type":1,"context":{"start":{"line":0,"character":0},"end":{"line":0,"character":0}}}. Aborting.
root DEBUG Registering new location: {"uri":"user_storage:settings.json","type":2,"context":{"range":{"start":{"line":5,"character":12},"end":{"line":5,"character":13}},"rangeLength":1,"text":"ö"}}.

Review checklist

Reminder for reviewers

It is hard to see anything when starting the app in debug mode.
Clients are free to adjust the log level in the launch configs:
Use `--log-level=trace`.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the changes :)

@vince-fugnitto vince-fugnitto added the logging issues related to logging label Jan 31, 2020
@kittaakos kittaakos merged commit a89f340 into master Jan 31, 2020
@kittaakos kittaakos deleted the relaxed-log-level branch January 31, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logging issues related to logging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants