Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix warnings on languages.ts #7163

Merged
merged 1 commit into from
Feb 17, 2020
Merged

fix warnings on languages.ts #7163

merged 1 commit into from
Feb 17, 2020

Conversation

amiramw
Copy link
Member

@amiramw amiramw commented Feb 16, 2020 •
edited
Loading

Signed-off-by: Amiram Wingarten amiram.wingarten@sap.com

What it does

Remove duplicate type and add readonly to a field.

How to test

N/A

Review checklist

Reminder for reviewers

@amiramw
fix warnings on languages.ts
17cb099 
Signed-off-by: Amiram Wingarten <amiram.wingarten@sap.com>
@akosyakov akosyakov added the plug-in system issues related to the plug-in system label Feb 17, 2020
@amiramw amiramw merged commit 1eaecd5 into eclipse-theia:master Feb 17, 2020
@amiramw amiramw deleted the warn branch February 17, 2020 08:16
@azatsarynnyy azatsarynnyy mentioned this pull request Feb 17, 2020
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azatsarynnyy azatsarynnyy azatsarynnyy approved these changes

@vince-fugnitto vince-fugnitto Awaiting requested review from vince-fugnitto

Assignees
No one assigned
Labels
plug-in system issues related to the plug-in system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amiramw @azatsarynnyy @akosyakov