fix #7393 can't open tomcat configuration without workspaces opened #7394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tom-shan thank you for the pull-request, as usual please |
…aces opened When no workspaces are opened, storagePath should return undefined in accordance with the vscode implementation(https://github.com/microsoft/vscode/blob/416bb2e8d08f123df4bfb458070fcbb9fb69a3da/src/vs/workbench/api/node/extHostStoragePaths.ts#L46-L49). Signed-off-by: tom-shan <swt0008411@163.com>
akosyakov
requested review from
mmorhun,
RomanNikitenko,
vince-fugnitto and
azatsarynnyy
vince-fugnitto
approved these changes
Mar 24, 2020
There was a problem hiding this comment.
The changes look fine to me, I can see that from their documentation vscode accepts undefined as a value:
I verified the changes against the reproduction steps outlined in #7393 and it worked successfully. I was able to modify the server configuration despite no workspace being opened, something which did not work on master.
|
@vince-fugnitto please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
When no workspaces are opened, storagePath should return undefined in
accordance with the vscode implementation(https://github.com/microsoft/vscode/blob/416bb2e8d08f123df4bfb458070fcbb9fb69a3da/src/vs/workbench/api/node/extHostStoragePaths.ts#L46-L49).
Then
vscode.ExtensionContext.storagePathwill return undefined and vscode tomcat will create a temp storagePath refer to https://github.com/adashen/vscode-tomcat/blob/develop/src/extension.ts#L13-L17.How to test
follow the Reproduction Steps in #7393,
and check whether the clicking of
Open Server Configurationis OK.Review checklist
Reminder for reviewers