Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsx: update extension information in the extension-editor #7439

Merged
merged 1 commit into from
Apr 2, 2020
Merged

vsx: update extension information in the extension-editor #7439

merged 1 commit into from
Apr 2, 2020

Conversation

kaiyue0329
Copy link
Contributor

Fixes: #7434

What it does

  • update styling for the action items in the extension header

How to test

  • Click View in the top menu and select Extensions
  • Search for an extension (ex. Bracket Pair Colorizer)
  • The styling for the action items should look similar to how they look in vscode:
    image

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added ui/ux issues related to user interface / user experience vsx-registry Issues related to Open VSX Registry Integration labels Mar 27, 2020
- update styling for the action items in the extension header

Signed-off-by: Kaiyue Pan <kaiyue.pan@ericsson.com>
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look great! 👍

With the changes we now have:

  • better spacing between subtitle items
  • better font-weight (closer to vscode), making it more readable
  • subtitle items are center-aligned and more consistent

Screen Shot 2020-03-27 at 3 45 40 PM

Copy link
Contributor

@Anasshahidd21 Anasshahidd21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried testing it. Looks good! Pretty similar as to how its done in vscode.
The padding looks decent and the menu-items no more looks too close to one another.

@vince-fugnitto vince-fugnitto merged commit d4e4d4b into eclipse-theia:master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux issues related to user interface / user experience vsx-registry Issues related to Open VSX Registry Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vsx: update extension information in the extension-editor
3 participants