Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eca: test if 'sign-off' is required #7602

Closed
wants to merge 1 commit into from
Closed

eca: test if 'sign-off' is required #7602

wants to merge 1 commit into from

Conversation

vince-fugnitto
Copy link
Member

What it does

Verify if the ECA successfully requires a sign-off to be present.

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto changed the title eca: test if 'sign-; eca: test if 'sign-off' is required Apr 17, 2020
@vince-fugnitto
Copy link
Member Author

@marcdumais-work maybe we should add back the DCO so that we ensure that commits are properly signed-off?

@marcdumais-work marcdumais-work mentioned this pull request Apr 17, 2020
Merged
1 task
@vince-fugnitto vince-fugnitto deleted the vf/test-eca branch April 20, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vince-fugnitto @marcdumais-work