Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

respect editor.maxTokenizationLineLength preference #7618

Merged
merged 1 commit into from
Apr 20, 2020
Merged

respect editor.maxTokenizationLineLength preference #7618

merged 1 commit into from
Apr 20, 2020

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Apr 20, 2020 •
edited
Loading

What it does

How to test

Review checklist

Reminder for reviewers

@akosyakov
Copy link
Member Author

cc @meysholdt

@akosyakov akosyakov added monaco issues related to monaco textmate issues related to the textmate grammars vscode issues related to VSCode compatibility labels Apr 20, 2020
@akosyakov
Copy link
Member Author

Spoke with @svenefftinge about it. VS Code default as 20000 sounds too much for big files for instance. I will try something smaller, with this PR end users and products can modify settings to make it work.

@akosyakov
fix #7617: respect editor. maxTokenizationLineLength preference
e4c5254 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov force-pushed the akosyakov/editor-maxtokenizationlinelength-7617 branch from b51b05b to e4c5254 Compare April 20, 2020 14:44
@akosyakov
Copy link
Member Author

@AlexTugarev I've reset the limit to 400 and reversed How to test section.

AlexTugarev
AlexTugarev approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised!

@akosyakov akosyakov merged commit 75dbd07 into master Apr 20, 2020
@akosyakov akosyakov deleted the akosyakov/editor-maxtokenizationlinelength-7617 branch April 20, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexTugarev AlexTugarev AlexTugarev approved these changes

@kittaakos kittaakos Awaiting requested review from kittaakos

@vince-fugnitto vince-fugnitto Awaiting requested review from vince-fugnitto

@RomanNikitenko RomanNikitenko Awaiting requested review from RomanNikitenko

@svenefftinge svenefftinge Awaiting requested review from svenefftinge

Assignees
No one assigned
Labels
monaco issues related to monaco textmate issues related to the textmate grammars vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

editor.maxTokenizationLineLength is not used leading to bogus coloring
2 participants
@akosyakov @AlexTugarev