Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation improvement #7640

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Documentation improvement #7640

merged 1 commit into from
Apr 22, 2020

Conversation

hnanacc
Copy link
Contributor

@hnanacc hnanacc commented Apr 21, 2020

Signed-off-by: Harshal Nandigramwar harshal.11711777@lpu.in

What it does

  1. Fixes typo in the node version mentioned in the Building on Windows section of Developing.md guide.
  2. Adds a reminder in the troubleshooting section in case somebody missed to read the docs.

How to test

This is a documentation enhancement and doesn't affect any code.

Review checklist

Reminder for reviewers

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bitbeast18 thank you for taking care of the issue, however please revert any unrelated changes (such as formatting).

@vince-fugnitto vince-fugnitto added the documentation issues related to documentation label Apr 21, 2020
@hnanacc
Copy link
Contributor Author

hnanacc commented Apr 21, 2020

@bitbeast18 thank you for taking care of the issue, however please revert any unrelated changes (such as formatting).

Thanks for reviewing @vince-fugnitto. I fixed the bad formatting.

@vince-fugnitto
Copy link
Member

@bitbeast18 please be sure to squash your commits, and sign-off before the pull-request can be accepted (at the moment the eclipsefdn/eca check is failing due to a missing sign-off).

@hnanacc
Copy link
Contributor Author

hnanacc commented Apr 21, 2020

@bitbeast18 please be sure to squash your commits, and sign-off before the pull-request can be accepted (at the moment the eclipsefdn/eca check is failing due to a missing sign-off).

@vince-fugnitto Squashed and signed. This is my first ever PR. Thanks for directions.

@hnanacc
Copy link
Contributor Author

hnanacc commented Apr 22, 2020

@vince-fugnitto
Is there some problem with the CI build system? There were no code changes and the last commit was passing the build but still, this one fails randomly.

Here is the stderr of 3 tries with some formatting https://gist.github.com/bitbeast18/2868be8ea1508fda1eadc7a2a279823c

For all the three tries there were warnings like these

root WARN Commiting pending changes before change accessor leaves due to read access.
root WARN Commiting pending changes before change accessor leaves due to read access.

but according to #7481 this was removed. Btw, the test was failing for yarn run test:browser

And then there was this unhandled error:

Error: Canceled: Canceled
    at Object.canceled (http://127.0.0.1:3000/vs/editor/editor.main.js:1618:21)
    at Delayer.cancel (http://127.0.0.1:3000/vs/editor/editor.main.js:9087:42)
    at http://127.0.0.1:3000/vs/editor/editor.main.js:116836:103
    at Object.dispose (http://127.0.0.1:3000/vs/editor/editor.main.js:5996:17)
    at http://127.0.0.1:3000/vs/editor/editor.main.js:6024:67
    at Set.forEach (<anonymous>)
    at DisposableStore.clear (http://127.0.0.1:3000/vs/editor/editor.main.js:6024:29)
    at DisposableStore.dispose (http://127.0.0.1:3000/vs/editor/editor.main.js:6018:18)
    at FindWidget.Disposable.dispose (http://127.0.0.1:3000/vs/editor/editor.main.js:6053:25)
    at http://127.0.0.1:3000/vs/editor/editor.main.js:6024:67

and a few Error: TypeError: Cannot read property 'addWidget' of null.

I don't exactly understand the problem.

doc/Developing.md Outdated Show resolved Hide resolved
…s section of Developing.md guide.

2. Adds a reminder in the troubleshooting section in case somebody
   misses to read the docs.

Signed-off-by: Harshal Nandigramwar <harshal.11711777@lpu.in>
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@akosyakov akosyakov merged commit 2dc8dc4 into eclipse-theia:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation issues related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants