-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow updating user-level task #7928
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tsmaeder do you mind updating the changelog
to reflect the breaking changes of the methods:
addTaskConfiguration
setTaskConfigurations
saveTask
@vince-fugnitto the only break folks overriding: calling should be ok. |
I see since: export type TaskConfigurationScope = string | TaskScope.Workspace | TaskScope.Global; My rationale was that it is always good practice to be explicit in the |
@vince-fugnitto thx for the heads-up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested in the following scenarios:
- updating problemMatchers for user tasks
- updating problemMatchers for configured tasks
- updating problemMatchers for contributed tasks
Thank you for your work.
It would be really helpful if the breaking changes can be documented in the changlog. Thank you !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested for user
and workspace
level tasks.
It works well for me!
Signed-off-by: Thomas Mäder <tmader@redhat.com>
9730fe9
to
f278160
Compare
Added a note about the breaking change. |
Signed-off-by: Thomas Mäder tmader@redhat.com
What it does
Allows to programmatically update user-level tasks. Fixes #7927
How to test
Check out this branch and test the scenario from the linked issue.
Review checklist
Reminder for reviewers