Bug fix (theia hanging on long lines) #8027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The proposed change will re-introduce this issue: #7617 |
|
@kittaakos I think it is a regression after #7617 Idea was to hook preferences, but not to change defaults. I've overlooked it. |
akosyakov
approved these changes
Jun 17, 2020
|
@jgaiao You have to sign ECA before we can merge it: https://github.com/eclipse-theia/theia/blob/master/CONTRIBUTING.md#eclipse-contributor-agreement |
editor.maxTokenizationLineLength default value changed back to 400, the value 20000 like in VS Code breaks on browser and some electrons when opening minified files. Signed-off-by: João Gaião <dactyllo@gmail.com>
|
Just added "Signed-off-by: Name " at the end of the commit message and signed the ECA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
editor.maxTokenizationLineLength default value changed back to 400, the value 20000 like in VS Code breaks on browser and some electrons when opening minified files.
Signed-off-by: João Gaião dactyllo@gmail.com