fix #7973: Collect env vars lowercase on windows

[dschafhauser]

What it does

• Fix issue Environment variables are not retrieved properly on Windows #7973
• Populate local copy of environment variables with lowercase keys if on Windows platform

How to test

1. Set two environment variables with different casing:

setx var_lower VAR_LOWER_value
setx VAR_UPPER VAR_UPPER_value

2. Start Theia locally on Windows and add the following tasks.json:

{
    "version": "2.0.0",
    "tasks": [
        {
            "label": "Echo",
            "type": "shell",
            "command": "echo Test var_lower=${env:var_lower} VAR_UPPER=${env:VAR_UPPER}",
            "problemMatcher": []
        }
    ]
}

3. Execute task "Echo".

Output before fix:

Test var_lower=VAR_LOWER_value VAR_UPPER=

Output after fix:

Test var_lower=VAR_LOWER_value VAR_UPPER=VAR_UPPER_value

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[kittaakos]

@dschafhauser, I have added the two new env variables with setx,

I started the backend, I added the sample Echo task and executed it but I do not see any of the variables; neither the lower nor the upper case.

I can confirm, Objects.keys(process.env).forEach does not contain my two variables. Any other ways to verify it? Thanks!

[akosyakov]

@kittaakos Do you need to restart Theia from a new terminal to pick up changes to env variables? I am not sure, maybe your Theia does not have it on startup. You could try to debug changed code and see whether process.env has them.

[lmcbout]

Sorry, I don't have a WINDOW environment to test it, someone else will have to test it

[dschafhauser]

I can confirm, Objects.keys(process.env).forEach does not contain my two variables. Any other ways to verify it? Thanks!

I think the following way should work more reliably.

Starting with a fresh CMD:

D:\theia> yarn
D:\theia> yarn run rebuild:electron
D:\theia> cd examples/electron
D:\theia\examples\electron> SET var_lower=VAR_LOWER_value
D:\theia\examples\electron> SET VAR_UPPER=VAR_UPPER_value
D:\theia\examples\electron> yarn run start

Could you try this, @kittaakos ?

[kittaakos]

I have verified it on Windows; it worked. I did the followings:

C:\Users\kittaakos\dev\git\theia>yarn rebuild:electron
yarn run v1.21.1
$ theia rebuild:electron
Processing @theia/node-pty
Processing nsfw
Processing native-keymap
Processing find-git-repositories
√ Rebuild Complete
Done in 66.52s.

C:\Users\kittaakos\dev\git\theia>SET var_lower=VAR_LOWER_value

C:\Users\kittaakos\dev\git\theia>SET VAR_UPPER=VAR_UPPER_value

C:\Users\kittaakos\dev\git\theia>echo %var_lower%
VAR_LOWER_value

C:\Users\kittaakos\dev\git\theia>echo %VAR_UPPER%
VAR_UPPER_value

C:\Users\kittaakos\dev\git\theia>echo %VAR_LOWER%
VAR_LOWER_value

C:\Users\kittaakos\dev\git\theia>echo %var_upper%
VAR_UPPER_value

C:\Users\kittaakos\dev\git\theia>yarn --cwd examples\\electron start
yarn run v1.21.1

[kittaakos]

Does anyone want to check on macOS/Linux?

[akosyakov]

Changes look good to me too, @kittaakos feel free to merge if the build is green.

[kittaakos]

Thank you for the fix, @dschafhauser 👍