debug: await handler's result #8117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have an internal product contributing said handler returning a Promise, and it wasn't working without this fix. The question now is "should handlers be async?" and so far I don't see a reason why not. |
akosyakov
approved these changes
Jun 30, 2020
A debug request handler can be implemented returning a Promise, which is not awaited. This commit adds the missing `await` statement. Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
paul-marechal
force-pushed
the
mp/debug-await-handler
branch
from
7c8ca72
to
09fb79f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A debug request handler can be implemented returning a Promise, which is
not awaited. This commit adds the missing
awaitstatement.How to test
N/A
Review checklist
Reminder for reviewers