[Plugin-API] Apply ResourceLabelFormatter API

[vinokurig]

Signed-off-by: Igor Vinokur ivinokur@redhat.com

What it does

Apply registerResourceLabelFormatter vscode Plugin-API function. It allows plugins to register a custom resource label formatters that specify how to display URIs. The test plugin registers a formatter:

theia.workspace.registerResourceLabelFormatter({
            scheme: 'file',
            formatting: {
                label: '${path} (formated)',
                separator: '/',
                tildify: true
            }
        });
    }));

CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=22392

How to test

1. Download the test plugin and put it to the plugins directory.

2. Start Theia workspace with some git project

3. Open some file.

4. Point the mouse cursor to the opened editor tab, see the tooltip:
   

5. Run F1 => Register Resource label formatter

6. Point the mouse cursor to the opened editor tab, see the tooltip that shows the formatted URI, which is added by the registered formatter:
   

7. Run F1 => Unregister formatter and see the original tooltip.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

fixes #7946

[vinokurig]

@eclipse-theia/plugin-system @eclipse-theia/core @akosyakov any updates?

[akosyakov]

It should be used to replace FileSystemUtils.tildifyPath correct?

[akosyakov]

@vinokurig It looks better, could you rebase please, address comments and squash commits (somehow some commit got changes from unrelated commits, hard to understad what they do). I will test then.

[vinokurig]

@akosyakov I squashed the commits, could you please review again

[akosyakov]

it is never used, did we forget some logic?

[vinokurig]

Removed the leftovers. In vscode it is used for the getWorkspaceLabel() function, but we are using only the getLongName() function

[akosyakov]

I think WorkspaceUriLabelProviderContribution.getLongName should respect it. That's a reason why we introduced workspace aware provider. We could handle it with a follow-up PR though. Please file an issue.

[akosyakov]

I could not find code which respects static resourceLabelFormatters contributions: https://code.visualstudio.com/api/references/contribution-points#contributes.resourceLabelFormatters

[akosyakov]

Code-wise looks good. With which version of git extension do you test? The latest does not work.

[akosyakov]

Unfortunately it is not feasible to verify with the git extension. A version which registers the label formatter does not work in Theia.

I've tested with the proposed sample and it worked as in How to test section. I've aslo verified that without registered formatters there are not regressions.

Please clean up the history, file a follow-up issue to support workspacePrefix API and merge. Thank you!