Made menu and keybinding contributions extensible #8188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From now on, downstream project can subclass and rebind various menu and keybinding contributions to overcome a Theia limitation. See: #8175 Signed-off-by: Akos Kitta <kittaakos@typefox.io>
vince-fugnitto
added
extensibility
vince-fugnitto
approved these changes
Jul 16, 2020
kittaakos
pushed a commit
that referenced
this pull request
Nov 7, 2020
From now on, the browser and electron frontends listen on different events when it comes to saving the app state and releasing the resources. The browser behavior is unchanged. Made the `will-prevent-unload` handling sync. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos
pushed a commit
that referenced
this pull request
Nov 12, 2020
- Moved the `beforeunload` handling logic to the frontend. - Removed the `attachWillPreventUnload` from the main electron app. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos
pushed a commit
that referenced
this pull request
Nov 13, 2020
- Moved the `beforeunload` handling logic to the frontend. - Removed the `attachWillPreventUnload` from the main electron app. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos
pushed a commit
that referenced
this pull request
Nov 13, 2020
- Moved the `beforeunload` handling logic to the frontend. - Removed the `attachWillPreventUnload` from the main electron app. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos
pushed a commit
that referenced
this pull request
Nov 13, 2020
- Moved the `beforeunload` handling logic to the frontend. - Removed the `attachWillPreventUnload` from the main electron app. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
paul-marechal
added a commit
that referenced
this pull request
Nov 13, 2020
Signed-off-by: Paul <paul.marechal@ericsson.com>
paul-marechal
added a commit
that referenced
this pull request
Nov 13, 2020
Signed-off-by: Paul <paul.marechal@ericsson.com>
paul-marechal
added a commit
that referenced
this pull request
Nov 13, 2020
Signed-off-by: Paul <paul.marechal@ericsson.com>
paul-marechal
pushed a commit
that referenced
this pull request
Nov 16, 2020
- Moved the `beforeunload` handling logic to the frontend. - Removed the `attachWillPreventUnload` from the main electron app. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
paul-marechal
pushed a commit
that referenced
this pull request
Nov 16, 2020
- Moved the `beforeunload` handling logic to the frontend. - Removed the `attachWillPreventUnload` from the main electron app. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos
pushed a commit
that referenced
this pull request
Nov 18, 2020
- Moved the `beforeunload` handling logic to the frontend. - Removed the `attachWillPreventUnload` from the main electron app. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From now on, downstream project can subclass and rebind various menu and
keybinding contributions to overcome a Theia limitation.
See: #8175
Signed-off-by: Akos Kitta kittaakos@typefox.io
What it does
FileandEditmenus: they must be the same as before.From now one, one can customize and rebind the
FileandEditmenu contributions to overcome #8175.This PR also makes the generic editor and the monaco keybinding contributions customizable.
How to test
Review checklist
Reminder for reviewers